[Relax][PyTorch] Add Pad Op Support for Exported Program and FX graph #17821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tvm-bot rerun |
1 similar comment
Contributor
Author
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/14396550088 Detailswith response |
Contributor
Author
|
@tvm-bot rerun |
1 similar comment
Contributor
Author
|
@tvm-bot rerun |
Deivanayaki-S
force-pushed
the
pad_op_support
branch
from
f7319c0 to
e1abc2c
Compare
|
I am just trying to convert pix2pix GAN model to TVM and came across this issue that currently no padding (ReflectionPad2d/ZeroPadding) is supported. Really thanks for this push and hope the change is pulled in soon. |
Contributor
Author
|
@Hzfengsy Could you please review this pr? |
Member
|
cc @tlopex |
Member
|
LGTM! Thanks! @Deivanayaki-S |
Hzfengsy
approved these changes
Apr 18, 2025
Member
|
Please address the conflict :) |
added 3 commits
April 18, 2025 03:44
fixing end of files formatting issue fixing trailing space issues update the docstring for pad mode in nn file fixing lint issues remove trailing whitespaces fix lint format issues in test script fix lint issue in pad file import statement modify docstring of pad function fixing dtype error in unity check fixing lint issues in pad.py file resolve arg mismatch error resolved error while handling pad value attr fix dtype of pad value attribute add helper function for different pad mode test script enhanced to check different pad mode remove trailing whitespaces in test script add docstring for helper function update test script
Deivanayaki-S
force-pushed
the
pad_op_support
branch
from
0fd7761 to
986ea7d
Compare
Contributor
Author
|
@Hzfengsy the conflict has been resolved. Thanks :) |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…apache#17821) * add pad op support into frontend pipelines fixing end of files formatting issue fixing trailing space issues update the docstring for pad mode in nn file fixing lint issues remove trailing whitespaces fix lint format issues in test script fix lint issue in pad file import statement modify docstring of pad function fixing dtype error in unity check fixing lint issues in pad.py file resolve arg mismatch error resolved error while handling pad value attr fix dtype of pad value attribute add helper function for different pad mode test script enhanced to check different pad mode remove trailing whitespaces in test script add docstring for helper function update test script * fix pad op arg handling in fx graph * fix issue by updated the retrieval of value arg --------- Co-authored-by: deivanayakisankaralingam <deiva@Deivanayaki>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the pad operation in Relax with handling for all common padding modes (constant, reflect, replicate, and circular). By adding this support, the following models are now able to run successfully: