[Relax] Refactor missing op check into shared utility for Torch frontends #17840
+18
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongwww
approved these changes
Apr 15, 2025
mshr-h
reviewed
Apr 16, 2025
mshr-h
approved these changes
Apr 16, 2025
Contributor
|
LGTM! Thanks for the tidy up! |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…ends (apache#17840) * combine missing op logic of export and fx graph into common utilities * move func call above builder and fix lint issue * add type hint for nodes in helper function --------- Co-authored-by: deivanayakisankaralingam <deiva@Deivanayaki>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the logic for detecting unsupported ops by moving _check_unsupported_func_type into a shared utility in base_fx_graph_translator.py file. Previously, this logic was implemented separately in both from_fx and from_exported_program. By centralizing this function, we reduce duplication and ensure consistent missing op reporting across Torch frontends.