Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix incorrect libcuda.so found by cmake when multiple versions of CUDA exist #1788

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Conversation

junrushao
Copy link
Member

@junrushao junrushao commented Oct 1, 2018

This PR contains a very minor fix and a modification in cmake.

  1. Enforce NO_DEFAULT_PATH when CUDA path is found. This particularly resolves my issue when building on the server in my university: when multiple CUDA versions exist, the original FindCUDA.cmake could possibly use incorrect libcuda.so.
  2. Print the dependencies found by FindXXXX explicitly. This could make it more friendly to developers who fail to build TVM due to dependency issues.

I posted details of this issue on the TVM forum: https://discuss.tvm.ai/t/incorrect-libcuda-so-when-multiple-versions-of-cuda-exist-problem-and-solution/886.

@junrushao
Copy link
Member Author

junrushao commented Oct 1, 2018

Re-triggering the CI: test_topi_matmul.test_matmul is flaky (See http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-1788/1/pipeline).

Related issue: #1784

@junrushao
Copy link
Member Author

junrushao commented Oct 1, 2018

A side note: It is undefined behavior to exit -1 in shells. Exit code should be unsigned int in [0, 255]. (http://pubs.opengroup.org/onlinepubs/7990989775/xcu/chap2.html#tag_001_014_007)

I noticed that this problem occurs every time when CI fails, so is it intended to return an undefined error code?

@junrushao
Copy link
Member Author

@tqchen Could you help review this? Thanks!

@tqchen tqchen merged commit e928109 into apache:master Oct 1, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
@junrushao junrushao deleted the fix-cmake branch January 6, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants