[Relax][PyTorch] Add MaxPool 1D and 3D Op Support for Exported Program and FX graph #17919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 5, 2025 11:50
Contributor
Author
|
@tlopex Could you pls review this pr? |
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…m and FX graph (apache#17919) * add max_pool 1d and 3d op support and refactor 2d op * update the layout used in max pool 1d op * add mappings into fx translator and fix lint issues * fix missing incorrect mappings and add module func * update output tensor struct info for maxpool1d * add docs for handling edge cases --------- Co-authored-by: deivanayakisankaralingam <deiva@Deivanayaki>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for max_pool1d and max_pool3d operations, extending the existing max_pool2d functionality to handle 1D and 3D pooling. It includes the necessary mappings, and comprehensive tests for these new operations. Additionally, maxpool2d was refactored to match the result of pytorch implementation. By adding this support, the 3DResNet torchvision model is now able to run successfully.