[REFACTOR][FFI] Cleanup container redirections #17929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
force-pushed
the
ffi-cpp
branch
5 times, most recently
from
9f1debc to
3151e7e
Compare
This PR cleans up the container redirections and headers so the files directly points to new ones in ffi folder - runtime/shape_tuple.h => ffi/container/shape.h - for IntTuple alias, introduce runtime/int_tuple.h for now - runtime/container/array.h => ffi/container/array.h - runtime/container/map.h => ffi/container/map.h - runtime/container/optional.h => ffi/optional.h - runtime/container/string.h => ffi/string.h - runtime/container/variant.h => ffi/container/variant.h - runtime/container/tuple.h => ffi/container/tuple.h We also introduce limited number of tvm::ffi classes into tvm namespace, when they are commonly used and their is no ambiguity.
MasterJH5574
approved these changes
May 8, 2025
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
This PR cleans up the container redirections and headers so the files directly points to new ones in ffi folder - runtime/shape_tuple.h => ffi/container/shape.h - for IntTuple alias, introduce runtime/int_tuple.h for now - runtime/container/array.h => ffi/container/array.h - runtime/container/map.h => ffi/container/map.h - runtime/container/optional.h => ffi/optional.h - runtime/container/string.h => ffi/string.h - runtime/container/variant.h => ffi/container/variant.h - runtime/container/tuple.h => ffi/container/tuple.h We also introduce limited number of tvm::ffi classes into tvm namespace, when they are commonly used and their is no ambiguity.
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
This PR cleans up the container redirections and headers so the files directly points to new ones in ffi folder - runtime/shape_tuple.h => ffi/container/shape.h - for IntTuple alias, introduce runtime/int_tuple.h for now - runtime/container/array.h => ffi/container/array.h - runtime/container/map.h => ffi/container/map.h - runtime/container/optional.h => ffi/optional.h - runtime/container/string.h => ffi/string.h - runtime/container/variant.h => ffi/container/variant.h - runtime/container/tuple.h => ffi/container/tuple.h We also introduce limited number of tvm::ffi classes into tvm namespace, when they are commonly used and their is no ambiguity.
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
This PR cleans up the container redirections and headers so the files directly points to new ones in ffi folder - runtime/shape_tuple.h => ffi/container/shape.h - for IntTuple alias, introduce runtime/int_tuple.h for now - runtime/container/array.h => ffi/container/array.h - runtime/container/map.h => ffi/container/map.h - runtime/container/optional.h => ffi/optional.h - runtime/container/string.h => ffi/string.h - runtime/container/variant.h => ffi/container/variant.h - runtime/container/tuple.h => ffi/container/tuple.h We also introduce limited number of tvm::ffi classes into tvm namespace, when they are commonly used and their is no ambiguity.
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
This PR cleans up the container redirections and headers so the files directly points to new ones in ffi folder - runtime/shape_tuple.h => ffi/container/shape.h - for IntTuple alias, introduce runtime/int_tuple.h for now - runtime/container/array.h => ffi/container/array.h - runtime/container/map.h => ffi/container/map.h - runtime/container/optional.h => ffi/optional.h - runtime/container/string.h => ffi/string.h - runtime/container/variant.h => ffi/container/variant.h - runtime/container/tuple.h => ffi/container/tuple.h We also introduce limited number of tvm::ffi classes into tvm namespace, when they are commonly used and their is no ambiguity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the container redirections and headers so the files directly points to new ones in ffi folder
We also introduce limited number of tvm::ffi classes into tvm namespace, when it is commonly used and their is no ambiguity.