[Relax][PyTorch] Add torch.outer Op Support for Exported Program and FX graph #17930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Hzfengsy
approved these changes
May 10, 2025
| R.output(gv) | ||
| return gv | ||
|
|
||
| input_infos = [ |
Member
There was a problem hiding this comment.
Better to update the format :)
Contributor
Author
There was a problem hiding this comment.
@Hzfengsy Lint CI check failed when this format was not followed
Hzfengsy
reviewed
May 10, 2025
Comment on lines
894
to
907
| input_infos = [ | ||
| ( | ||
| [ | ||
| 3, | ||
| ], | ||
| "float32", | ||
| ), | ||
| ( | ||
| [ | ||
| 4, | ||
| ], | ||
| "float32", | ||
| ), | ||
| ] |
Member
There was a problem hiding this comment.
Suggested change
| input_infos = [ | |
| ( | |
| [ | |
| 3, | |
| ], | |
| "float32", | |
| ), | |
| ( | |
| [ | |
| 4, | |
| ], | |
| "float32", | |
| ), | |
| ] | |
| input_infos = [([3], "float32"), ([4], "float32")] | |
Contributor
Author
There was a problem hiding this comment.
@Hzfengsy Thanks! I've updated the format, and the lint check has passed successfully :)
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…FX graph (apache#17930) * add torch.outer op support into exported program and fx translator * fix lint issues * fix cpp lints * update the format of input info n fx test script --------- Co-authored-by: deivanayakisankaralingam <deiva@Deivanayaki>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the torch.outer operation in exported program and fx graph translator torch frontend. By adding this support, the Sentence similarity nomic-ai/nomic-embed-text-v1.5 model is now able to run successfully: