Add registion for the operator erf in llvm #17992
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tvm-bot rerun |
jikechao
approved these changes
Jul 2, 2025
Member
jikechao
left a comment
jikechao
left a comment
There was a problem hiding this comment.
LGTM, It would be better to implement a higher-precision version of erf() in a future update.
Contributor
|
This proposal here was stalled and we got a ERF proposal merged by #18104 (Abramowitz & Stegun variant). Since now this is a duplicate, it could be closed if there are no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is designed to fix #17975 by supporting the operators of erf in the LLVM backend.
It was implemented by using the approximation for erf(x)
as shown in https://en.wikipedia.org/wiki/Error_function