Fix zero-extent loops in PerStoreFeature to prevent crashes #17995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Hzfengsy,
MasterJH5574,
tqchen and
vinx13
Hzfengsy
approved these changes
May 21, 2025
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…7995) Update per_store_feature.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch gracefully handles zero-extent loops (like those from empty indices in
take()ops) by returningEvaluate(0)in PerStoreFeature, preventingCHECK(p < n_loops)crashes.This restores auto-tuning for empty-input edge cases while perfectly preserving existing feature extraction for normal loops.
Fix #17994
cc @Hzfengsy @tqchen @vinx13 @MasterJH5574