Skip to content

[Relax][Frontend][ONNX] Fix: bitwise_not misclassified as binary (is … #18001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hzfengsy merged 3 commits into from
May 22, 2025
Merged

[Relax][Frontend][ONNX] Fix: bitwise_not misclassified as binary (is … #18001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04dab05
[Relax][Frontend][ONNX] Fix: bitwise_not misclassified as binary (is …
eaten-cake May 20, 2025
d6c9682
Merge branch 'apache:main' into main
eaten-cake May 22, 2025
f4e9505
Verify whether CI supports opset 18.
eaten-cake May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions python/tvm/relax/frontend/onnx/onnx_frontend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,15 +564,14 @@ def _impl_v18(cls, bb, inputs, attr, params):
return cls.base_impl(bb, inputs, attr, params)


class BitwiseNot(BitwiseBase):
class BitwiseNot(OnnxOpConverter):
"""Converts an onnx BitwiseNot node into an equivalent Relax expression."""

numpy_op = _np.bitwise_not
relax_op = relax.op.bitwise_not

@classmethod
def _impl_v18(cls, bb, inputs, attr, params):
return cls.base_impl(bb, inputs, attr, params)
if isinstance(inputs[0], relax.Constant):
return relax.const(_np.bitwise_not(inputs[0].data.numpy()), inputs[0].struct_info.dtype)
return relax.op.bitwise_not(inputs[0])


class BitShift(BitwiseBase):
Expand Down Expand Up @@ -3117,13 +3116,13 @@ def _get_convert_map():
"BitwiseAnd": BitwiseAnd,
"BitwiseOr": BitwiseOr,
"BitwiseXor": BitwiseXor,
"BitwiseNot": BitwiseNot,
"BitShift": BitShift,
"And": And,
"Or": Or,
"Xor": Xor,
"Not": Not,
# Unary operators
"BitwiseNot": BitwiseNot,
"Log": Log,
"Exp": Exp,
"Acos": Acos,
Expand Down
3 changes: 0 additions & 3 deletions tests/python/relax/test_frontend_onnx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,13 +402,11 @@ def test_binary_bool(op_name: str):
verify_binary(op_name, [32, 32], [32, 32], [32, 32], dtype=TensorProto.BOOL)


@pytest.mark.skip(reason="opset 18 is not supported in CI")
@pytest.mark.parametrize("op_name", ["BitwiseAnd", "BitwiseOr", "BitwiseXor"])
def test_bitwise(op_name: str):
verify_binary(op_name, [32, 32], [32, 32], [32, 32], dtype=TensorProto.UINT64, opset=18)


@pytest.mark.skip(reason="opset 18 is not supported in CI")
def test_bitwise_not():
verify_unary(
"BitwiseNot",
Expand Down Expand Up @@ -945,7 +943,6 @@ def test_selu():
verify_unary("Selu", [3, 32, 32], attrs={"alpha": 0.25, "gamma": 0.3})


@pytest.mark.skip(reason="opset 18 is not supported in CI")
def test_mish():
verify_unary("Mish", [3, 32, 32], opset=18)

Expand Down