Skip to content

Add op support for slice_scatter #18019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tlopex merged 2 commits into from
May 28, 2025
Merged

Add op support for slice_scatter #18019

tlopex merged 2 commits into from
May 28, 2025

Conversation

@kavin-sai-krishna
Copy link
Contributor

@kavin-sai-krishna kavin-sai-krishna commented May 27, 2025

This PR adds support for the slice_scatter op in exported program and fx graph translator torch frontend.

@Hzfengsy Hzfengsy assigned Hzfengsy and tlopex and unassigned Hzfengsy May 28, 2025
tlopex
tlopex approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@tlopex tlopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tlopex tlopex merged commit 29de9ab into apache:main May 28, 2025
11 of 12 checks passed
@tqchen
Copy link
Member

tqchen commented Jun 5, 2025 •
edited
Loading

Some checklist for adding a new op.

  • C0: Can the operator be decomposed into smaller ops (if so, then it may not be necessary to introduce the high-level op). It is helpful to reuse existing ops when possible so we don't have to introduce C1/C2, otherwise we need C1/C2
  • C1: Introduce legalization rules so the op at least compiles on CPU
  • C2: Make sure the op compiles on CUDA

@tqchen
Copy link
Member

tqchen commented Jun 5, 2025

it would be good to followup to check the above check list

@ysh329 ysh329 mentioned this pull request Jul 16, 2025
Closed
ShiboXing pushed a commit to ShiboXing/tvm that referenced this pull request Aug 10, 2025
@kavin-sai-krishna @ShiboXing
Add op support for slice_scatter (apache#18019)
b4a7989 
* Implement slice_scatter e2e

* Fix lint issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlopex tlopex tlopex approved these changes

Assignees

@tlopex tlopex

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kavin-sai-krishna @tqchen @tlopex @Hzfengsy