[Script] Remove deprecated attributes from Constant AST node #18066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hzfengsy
changed the title
Remove the deprecated `s` and `n` attributes from the `Constant` AST node class in the script parser. These attributes were previously used for string and numeric constants but are no longer needed in the current AST implementation. Updated all code that creates `Constant` objects to remove the corresponding parameters: - Removed `s` and `n` parameters from `Constant.__init__` - Updated `_FIELDS` list to exclude deprecated attributes - Fixed calls in `evaluator.py` and `parser.py` to remove extra arguments This change simplifies the AST structure and removes unused legacy code.
Hzfengsy
force-pushed
the
parser_remove_deprecated_attr
branch
from
d85d5d3 to
36f7413
Compare
tqchen
approved these changes
Jun 17, 2025
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…18066) [ARITH] Remove deprecated attributes from Constant AST node Remove the deprecated `s` and `n` attributes from the `Constant` AST node class in the script parser. These attributes were previously used for string and numeric constants but are no longer needed in the current AST implementation. Updated all code that creates `Constant` objects to remove the corresponding parameters: - Removed `s` and `n` parameters from `Constant.__init__` - Updated `_FIELDS` list to exclude deprecated attributes - Fixed calls in `evaluator.py` and `parser.py` to remove extra arguments This change simplifies the AST structure and removes unused legacy code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deprecated
sandnattributes from theConstantAST node class in the script parser. These attributes were previously used for string and numeric constants but are no longer needed in the current AST implementation.Updated all code that creates
Constantobjects to remove the corresponding parameters:sandnparameters fromConstant.__init___FIELDSlist to exclude deprecated attributesevaluator.pyandparser.pyto remove extra argumentsThis change simplifies the AST structure and removes unused legacy code.