Skip to content

[NVSHMEM] Update NDArray allocation #18073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 1 commit into from
Jun 17, 2025
Merged

[NVSHMEM] Update NDArray allocation #18073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/runtime/contrib/nvshmem/memory_allocator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,18 @@ class NVSHMEMAllocator final : public PooledAllocator {
}

NDArray Empty(ffi::Shape shape, DataType dtype, Device device) {
NDArray::Container* container = new NDArray::Container(nullptr, shape, dtype, device);
container->SetDeleter([](Object* obj) {
auto* ptr = static_cast<NDArray::Container*>(obj);
ICHECK(ptr->manager_ctx != nullptr);
Buffer* buffer = reinterpret_cast<Buffer*>(ptr->manager_ctx);
NVSHMEMAllocator::Global()->Free(*(buffer));
delete buffer;
delete ptr;
});
Buffer* buffer = new Buffer;
*buffer = PooledAllocator::Alloc(device, shape, dtype, String("nvshmem"));
container->manager_ctx = reinterpret_cast<void*>(buffer);
container->dl_tensor.data = buffer->data;
return NDArray(GetObjectPtr<Object>(container));
class NVSHMEMAlloc {
public:
explicit NVSHMEMAlloc(Buffer buffer) : buffer_(buffer) {}
void AllocData(DLTensor* tensor) { tensor->data = buffer_.data; }
void FreeData(DLTensor* tensor) { NVSHMEMAllocator::Global()->Free(buffer_); }

private:
Buffer buffer_;
};

Buffer buffer = PooledAllocator::Alloc(device, shape, dtype, String("nvshmem"));
return NDArray::FromNDAlloc(NVSHMEMAlloc(buffer), shape, dtype, device);
}

private:
Expand Down
Loading