-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend][MXNet] ones zeros ones_like zeros_like ops support #1814
Conversation
@imorinaga Could you rebase against the most recent master? |
1922080
to
9e97398
Compare
@nishi-t Thank you for comments! rebase done. |
please add tests for these operators |
@imorinaga Any updates? |
argmax and argmin support is deleted. |
Thank you for adding tests. If the point you have pointed out is a testing problem for argmin and argmax, #1908 may be able to fix it. |
Thank you for comment! |
@imorinaga OK. I don't have sure knowledge of the return type and couldn't confirm it from the document. But, If argmin and argmax return the indices as float32 in mxnet, we would need to discuss how to support it. |
@nishi-t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imorinaga Ok, Thanks. LGTM
@imorinaga yes, I'd suggest changing the title. |
This PR supports 6 symbols in MXNet frontend.
@srkreddy1238 @nishi-t Could you please do the review. Thanks.