[BugFix][NNAPI] Fix type mismatch and test_mean annotation #18140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit explicitly casts the `tvm::ffi::Any` returned by `runtime.nnapi_runtime_create` to `tvm::runtime::Module` before adding it to the `Array<runtime::Module>` in response to the recent FFI refactor (commit 2d964b4) that phased out the legacy C API. Co-authored-by: HMZ <mzhuang@pllab.cs.nthu.edu.tw>
This commit corrects the StructInfo annotation of the tensor returned by `R.mean` from `(1, 10, 15)` to `(1, 10, 1)` to match the actual output shape. Co-authored-by: HMZ <mzhuang@pllab.cs.nthu.edu.tw>
tqchen
approved these changes
Jul 14, 2025
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
) * [BugFix][NNAPI] Fix type mismatch in NNAPICompiler This commit explicitly casts the `tvm::ffi::Any` returned by `runtime.nnapi_runtime_create` to `tvm::runtime::Module` before adding it to the `Array<runtime::Module>` in response to the recent FFI refactor (commit 2d964b4) that phased out the legacy C API. Co-authored-by: HMZ <mzhuang@pllab.cs.nthu.edu.tw> * [BugFix][NNAPI] Fix annotation in test_mean This commit corrects the StructInfo annotation of the tensor returned by `R.mean` from `(1, 10, 15)` to `(1, 10, 1)` to match the actual output shape. Co-authored-by: HMZ <mzhuang@pllab.cs.nthu.edu.tw> --------- Co-authored-by: HMZ <mzhuang@pllab.cs.nthu.edu.tw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two small fixes for the Relax NNAPI backend introduced in PR #17385:
NNAPICompilerby castingtvm::ffi::Anytotvm::runtime::Module.test_mean.Verified locally with successful compilation and test run.
Co-authored-by: HMZ mzhuang@pllab.cs.nthu.edu.tw