[FFI][REFACTOR] Phase out TVM_FFI_REGISTER_GLOBAL in favor of GlobalDef #18148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
In the previous reflection design and implementation it can be used in runtime, because its runtime overhead is too big to runtime code. Does the new reflection can be used in runtime code or not? If so does it introduce extra obvious runtime overhead？Thanks. |
Member
Author
|
thanks @Johnson9009 yes, it is effectively the same thing, just different syntax sugar. so it will have the same overhead as original one |
This PR migrates the remaining global def reg to use the new mechanism. It also phases out the TVM_FFI_REGISTER_GLOBAL macro in favor of the GlobalDef mechanism.
ShiboXing
pushed a commit
to ShiboXing/tvm
that referenced
this pull request
Aug 10, 2025
…ef (apache#18148) This PR migrates the remaining global def reg to use the new mechanism. It also phases out the TVM_FFI_REGISTER_GLOBAL macro in favor of the GlobalDef mechanism.
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
…ef (apache#18148) This PR migrates the remaining global def reg to use the new mechanism. It also phases out the TVM_FFI_REGISTER_GLOBAL macro in favor of the GlobalDef mechanism.
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
…ef (apache#18148) This PR migrates the remaining global def reg to use the new mechanism. It also phases out the TVM_FFI_REGISTER_GLOBAL macro in favor of the GlobalDef mechanism.
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Sep 13, 2025
…ef (apache#18148) This PR migrates the remaining global def reg to use the new mechanism. It also phases out the TVM_FFI_REGISTER_GLOBAL macro in favor of the GlobalDef mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the remaining global def reg to use the new mechanism. It also phases out the TVM_FFI_REGISTER_GLOBAL macro in favor of the GlobalDef mechanism.