Skip to content

[FFI][Bugfix] Enable load_inline on macos #18285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasterJH5574 merged 2 commits into from
Sep 9, 2025
Merged

[FFI][Bugfix] Enable load_inline on macos #18285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4aa885
link libtvm_ffi.dylib
yaoyaoding Sep 8, 2025
ed653e2
remove skip for tests
yaoyaoding Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ffi/python/tvm_ffi/cpp/load_inline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ def _generate_ninja_build(
"""Generate the content of build.ninja for building the module."""
default_include_paths = [find_include_path(), find_dlpack_include_path()]

tvm_ffi_lib = find_libtvm_ffi()
tvm_ffi_lib_path = os.path.dirname(tvm_ffi_lib)
tvm_ffi_lib_name = os.path.splitext(os.path.basename(tvm_ffi_lib))[0]
if IS_WINDOWS:
default_cflags = [
"/std:c++17",
Expand All @@ -157,17 +160,11 @@ def _generate_ninja_build(
"/EHsc",
]
default_cuda_cflags = ["-Xcompiler", "/std:c++17", "/O2"]
# Find the TVM FFI library for linking
tvm_ffi_lib = find_libtvm_ffi()
tvm_ffi_lib_path = os.path.dirname(tvm_ffi_lib)
tvm_ffi_lib_name = os.path.splitext(os.path.basename(tvm_ffi_lib))[
0
] # Remove .dll extension
default_ldflags = ["/DLL", f"/LIBPATH:{tvm_ffi_lib_path}", f"{tvm_ffi_lib_name}.lib"]
else:
default_cflags = ["-std=c++17", "-fPIC", "-O2"]
default_cuda_cflags = ["-Xcompiler", "-fPIC", "-std=c++17", "-O2"]
default_ldflags = ["-shared"]
default_ldflags = ["-shared", "-L{}".format(tvm_ffi_lib_path), "-ltvm_ffi"]

if with_cuda:
# determine the compute capability of the current GPU
Expand Down
16 changes: 0 additions & 16 deletions ffi/tests/python/test_load_inline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@
from tvm_ffi.module import Module


@pytest.mark.xfail(
not sys.platform.startswith("linux") and not sys.platform.startswith("win32"),
reason="need to support other platforms",
)
def test_load_inline_cpp():
mod: Module = tvm_ffi.cpp.load_inline(
name="hello",
Expand All @@ -58,10 +54,6 @@ def test_load_inline_cpp():
numpy.testing.assert_equal(x + 1, y)


@pytest.mark.xfail(
not sys.platform.startswith("linux") and not sys.platform.startswith("win32"),
reason="need to support other platforms",
)
def test_load_inline_cpp_with_docstrings():
mod: Module = tvm_ffi.cpp.load_inline(
name="hello",
Expand All @@ -88,10 +80,6 @@ def test_load_inline_cpp_with_docstrings():
numpy.testing.assert_equal(x + 1, y)


@pytest.mark.xfail(
not sys.platform.startswith("linux") and not sys.platform.startswith("win32"),
reason="need to support other platforms",
)
def test_load_inline_cpp_multiple_sources():
mod: Module = tvm_ffi.cpp.load_inline(
name="hello",
Expand Down Expand Up @@ -134,10 +122,6 @@ def test_load_inline_cpp_multiple_sources():
numpy.testing.assert_equal(x + 1, y)


@pytest.mark.xfail(
not sys.platform.startswith("linux") and not sys.platform.startswith("win32"),
reason="need to support other platforms",
)
def test_load_inline_cpp_build_dir():
mod: Module = tvm_ffi.cpp.load_inline(
name="hello",
Expand Down