Skip to content

[Python] Add library lookup path for tvm installed as a pakcage #18348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlopex merged 1 commit into from
Sep 27, 2025
Merged

[Python] Add library lookup path for tvm installed as a pakcage #18348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/tvm/libinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ def get_dll_directories():

# Pip lib directory
dll_path.append(ffi_dir)
dll_path.append(os.path.join(ffi_dir, "lib"))
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change effectively resolves the library loading issue. However, it appears to be a workaround for an underlying inconsistency in the installation process. It seems CMakeLists.txt has duplicate install directives for the tvm and tvm_runtime libraries, which can lead to them being placed in different directories based on the build context (e.g., pip install vs. a manual make install).

For better long-term maintainability, we should consider addressing the root cause in the CMake setup to ensure libraries are always installed to a single, predictable location. This would simplify the library discovery logic and make the packaging more robust.

# Default cmake build directory
dll_path.append(os.path.join(source_dir, "build"))
dll_path.append(os.path.join(source_dir, "build", "Release"))
Expand Down
Loading