Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check iter_type in vectorize #1921

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Check iter_type in vectorize #1921

merged 1 commit into from
Oct 19, 2018

Conversation

izgzhen
Copy link
Contributor

@izgzhen izgzhen commented Oct 18, 2018

fixes #1795

wweic
wweic reviewed Oct 18, 2018
View reviewed changes
Copy link
Contributor

@wweic wweic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to add test-cases to cover the new features or bugfix the patch introduces. So probably add a unit test(probably in test_lang_schedule.py) to make sure exception is correctly thrown, like https://github.com/dmlc/tvm/blob/dc996e451a3fee9dffefc31b652b6e85a72cb041/tests/python/unittest/test_pass_split_host_device.py#L4-L14

@tqchen tqchen added the status: need update need update based on feedbacks label Oct 18, 2018
@tqchen
Copy link
Member

tqchen commented Oct 18, 2018

Thanks for the contribution! please add a test case as @wweic suggested

@izgzhen
Copy link
Contributor Author

izgzhen commented Oct 19, 2018

@wweic @tqchen Thanks a lot! I've updated and waited for CI now

@tqchen tqchen merged commit f928124 into apache:master Oct 19, 2018
@tqchen
Copy link
Member

tqchen commented Oct 19, 2018 •
edited
Loading

Thanks @izgzhen @wweic this is now merged

@tqchen tqchen added status: accepted and removed status: need update need update based on feedbacks labels Oct 19, 2018
@tqchen tqchen mentioned this pull request Oct 19, 2018
Closed
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
@izgzhen @tqchen
Check iter_type in vectorize (apache#1921)
c96ab9d
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@izgzhen
Check iter_type in vectorize (apache#1921)
2a732f5
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@izgzhen
Check iter_type in vectorize (apache#1921)
858aab0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wweic wweic wweic left review comments

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vectorizing a reduce_axis does not raise an error
3 participants
@izgzhen @tqchen @wweic