-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YOLO]yolo op added in frontend and removed from topi #1974
Conversation
90f9827
to
3961f81
Compare
3961f81
to
71499d7
Compare
cc @PariksheetPinjari909 @masahi @yzhliu please review |
As yolo, region are not generic ops and looking at the progress of darknet, moving these ops to frontend is a good idea. Thanks @siju-samuel for bringing in this PR. Let's check if we can bring region to frontend as well. Any views on this @yzhliu |
@PariksheetPinjari909 I have already tried this.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @PariksheetPinjari909 @siju-samuel this is merged |
The yolo op is used only in darknet and since its not generic and can be acheived by frontend itself, i implemented the op in darknet.py and removed all the existing yolo_op registration, testcases and topi code.
@PariksheetPinjari909 @yzhliu Please review. Thanks in advance.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.