[RELAY]prelu op support #2016
Merged
[RELAY]prelu op support #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srkreddy1238 @nishi-t @slyubomirsky @yuruofeifei @MarisaKirisame Could you please help in reviewing this PR. TIA |
|
LGTM, good test coverage |
tqchen
requested changes
Oct 29, 2018
src/relay/op/nn/nn.cc
Outdated
| CHECK(ndim == 4) | ||
| << "Input data should be 4D, but got " << ndim; | ||
|
|
||
| CHECK(reporter->Assert(param->axis < make_const(Int(64), ndim))) |
There was a problem hiding this comment.
We should avoid the abusive use of symbolic Assert, specifically, since param->axis is int, which means we can directly check int relations. Assert is only needed if one of the input expression is symbolic
There was a problem hiding this comment.
This seems to be a common mistake pattern in recent PRs, can you add more comments to Assert to actually document the possible misuse cases and the intention of the API?
src/relay/op/nn/nn.cc
Outdated
| CHECK(param != nullptr); | ||
|
|
||
| size_t ndim = data->shape.size(); | ||
| CHECK(ndim == 4) |
There was a problem hiding this comment.
This operator don't need to have this restriction
siju-samuel
force-pushed
the
relay_prelu
branch
from
0f73318
to
6e9984b
Compare
tqchen
approved these changes
Oct 29, 2018
|
Thanks @slyubomirsky @siju-samuel this is now merged |
eqy
pushed a commit
to eqy/tvm
that referenced
this pull request
Oct 29, 2018
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1799
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.