Do not mutate GlobalVar's checked_type field. #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tqchen
approved these changes
Oct 29, 2018
eqy
pushed a commit
to eqy/tvm
that referenced
this pull request
Oct 29, 2018
eqy
pushed a commit
to eqy/tvm
that referenced
this pull request
Oct 29, 2018
eqy
pushed a commit
to eqy/tvm
that referenced
this pull request
Oct 29, 2018
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the type checker to no longer mutate the checked_type field of
tvm::relay::GlobalVar. The checked_type field is suppose to enable populating results of local analysis to the entire AST. The problem istvm::relay::GlobalVar's are shared across the entire system, and duplicating or mutating them causes challenges.One example is demonstrated in attached test case.