-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VTA] Improved RPC for VTA #2043
Conversation
`build/vta_config.json` => `vta/config/vta_config.json`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @liangfu for these improvements! Would you mind addressing my two comments? The most important part is to make sure that the tutorial instructions can still allow us to deploy our examples. Thanks!
@tmoreau89 Thank you for your instructions. I have made the following change to reflect the design decision:
On the other hand, since the source code under |
@liangfu renaming the metal tests is a good idea since the aim is to have mostly a device independent workflow |
@tmoreau89 renamed and pushed, please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please undo the change in rpc_server.py, but otherwise, it's ready to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @liangfu for the enhancements!
* assign default port to 9091 as the documented * bug fix in printing RuntimeError and add an additional search path * pretty print rebuild runtime args * PRC => RPC * replace vta_config.json file path `build/vta_config.json` => `vta/config/vta_config.json` * undo the change in adding lib_search path * search vta_config.py file in vta/config * avoid exposing driver function calls, and use predefined `VTAMemGetPhyAddr` instead. * rename `tests/hardware/pynq` => `metal_test` * set config path back to `build` dir
* assign default port to 9091 as the documented * bug fix in printing RuntimeError and add an additional search path * pretty print rebuild runtime args * PRC => RPC * replace vta_config.json file path `build/vta_config.json` => `vta/config/vta_config.json` * undo the change in adding lib_search path * search vta_config.py file in vta/config * avoid exposing driver function calls, and use predefined `VTAMemGetPhyAddr` instead. * rename `tests/hardware/pynq` => `metal_test` * set config path back to `build` dir
* assign default port to 9091 as the documented * bug fix in printing RuntimeError and add an additional search path * pretty print rebuild runtime args * PRC => RPC * replace vta_config.json file path `build/vta_config.json` => `vta/config/vta_config.json` * undo the change in adding lib_search path * search vta_config.py file in vta/config * avoid exposing driver function calls, and use predefined `VTAMemGetPhyAddr` instead. * rename `tests/hardware/pynq` => `metal_test` * set config path back to `build` dir
* assign default port to 9091 as the documented * bug fix in printing RuntimeError and add an additional search path * pretty print rebuild runtime args * PRC => RPC * replace vta_config.json file path `build/vta_config.json` => `vta/config/vta_config.json` * undo the change in adding lib_search path * search vta_config.py file in vta/config * avoid exposing driver function calls, and use predefined `VTAMemGetPhyAddr` instead. * rename `tests/hardware/pynq` => `metal_test` * set config path back to `build` dir
Changes
libvta.so
@tmoreau89 would you please review this PR?