Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTA] Improved RPC for VTA #2043

Merged
merged 10 commits into from
Nov 12, 2018
Merged

[VTA] Improved RPC for VTA #2043

merged 10 commits into from
Nov 12, 2018

Conversation

liangfu
Copy link
Member

@liangfu liangfu commented Oct 31, 2018

Changes

  • assign default RPC port to 9091, which is used in the client and described in the document
  • bug fix in printing RuntimeError and add an additional search path for libvta.so
  • pretty print rebuild runtime arguments
  • PRC => RPC

@tmoreau89 would you please review this PR?

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @liangfu for these improvements! Would you mind addressing my two comments? The most important part is to make sure that the tutorial instructions can still allow us to deploy our examples. Thanks!

vta/python/vta/exec/rpc_server.py Outdated Show resolved Hide resolved
vta/python/vta/libinfo.py Outdated Show resolved Hide resolved
@liangfu
Copy link
Member Author

liangfu commented Nov 7, 2018

@tmoreau89 Thank you for your instructions. I have made the following change to reflect the design decision:

  1. undo the change in adding lib_search path
  2. defaulting vta_config.py file to vta/config in vta/tests/hardware/pynq/Makefile

On the other hand, since the source code under vta/tests/hardware/pynq seems to be device independent, can we rename the directory vta/tests/hardware/pynq to something like vta/tests/hardware/metal_test, and make metal_test available for devices like ultra96 and de10-nano as well?

@tmoreau89
Copy link
Contributor

@liangfu renaming the metal tests is a good idea since the aim is to have mostly a device independent workflow

@liangfu
Copy link
Member Author

liangfu commented Nov 12, 2018

@tmoreau89 renamed and pushed, please review.

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please undo the change in rpc_server.py, but otherwise, it's ready to merge!

vta/python/vta/exec/rpc_server.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @liangfu for the enhancements!

@tmoreau89 tmoreau89 merged commit b88065a into apache:master Nov 12, 2018
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
* assign default port to 9091 as the documented

* bug fix in printing RuntimeError and add an additional search path

* pretty print rebuild runtime args

* PRC => RPC

* replace vta_config.json file path

`build/vta_config.json` => `vta/config/vta_config.json`

* undo the change in adding lib_search path

* search vta_config.py file in vta/config

* avoid exposing driver function calls, and use predefined `VTAMemGetPhyAddr` instead.

* rename `tests/hardware/pynq` => `metal_test`

* set config path back to `build` dir
@ZihengJiang ZihengJiang mentioned this pull request Feb 1, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
* assign default port to 9091 as the documented

* bug fix in printing RuntimeError and add an additional search path

* pretty print rebuild runtime args

* PRC => RPC

* replace vta_config.json file path

`build/vta_config.json` => `vta/config/vta_config.json`

* undo the change in adding lib_search path

* search vta_config.py file in vta/config

* avoid exposing driver function calls, and use predefined `VTAMemGetPhyAddr` instead.

* rename `tests/hardware/pynq` => `metal_test`

* set config path back to `build` dir
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
* assign default port to 9091 as the documented

* bug fix in printing RuntimeError and add an additional search path

* pretty print rebuild runtime args

* PRC => RPC

* replace vta_config.json file path

`build/vta_config.json` => `vta/config/vta_config.json`

* undo the change in adding lib_search path

* search vta_config.py file in vta/config

* avoid exposing driver function calls, and use predefined `VTAMemGetPhyAddr` instead.

* rename `tests/hardware/pynq` => `metal_test`

* set config path back to `build` dir
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
* assign default port to 9091 as the documented

* bug fix in printing RuntimeError and add an additional search path

* pretty print rebuild runtime args

* PRC => RPC

* replace vta_config.json file path

`build/vta_config.json` => `vta/config/vta_config.json`

* undo the change in adding lib_search path

* search vta_config.py file in vta/config

* avoid exposing driver function calls, and use predefined `VTAMemGetPhyAddr` instead.

* rename `tests/hardware/pynq` => `metal_test`

* set config path back to `build` dir
@liangfu liangfu deleted the patch-5 branch April 14, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants