REGION op removed from topi and added in darkent frontend #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siju-samuel
force-pushed
the
remove_region
branch
from
41af088
to
36497d4
Compare
siju-samuel
force-pushed
the
remove_region
branch
from
36497d4
to
35e4534
Compare
|
please request reviews |
|
What is the status on this PR? |
|
@siju-samuel please rebase the PR against the latest master |
|
@srkreddy1238 @PariksheetPinjari909 please review |
PariksheetPinjari909
suggested changes
Jan 14, 2019
nnvm/python/nnvm/frontend/darknet.py
Outdated
| data_block_1 = splits[:offset] | ||
| splits = data_block_1 + [softmax_output] | ||
| concat_out = _sym.concatenate(*splits, axis=2) | ||
| return _sym.reshape(concat_out, shape=input_shape), None |
There was a problem hiding this comment.
Split the data block at (2, 4, 5) locations and apply sigmoid and softmax as follows:
data_block = _sym.reshape(inputs[0], shape=intermediate_shape)
split_indices = (2, 4, 5)
split_res = _sym.split(data_block, indices_or_sections=split_indices, axis=2)
split_res0 = _sym.sigmoid(split_res[0])
if not background:
split_res2 = _sym.sigmoid(split_res[2])
else:
split_res2 = split_res[2]
if softmax:
split_res3 = _sym.softmax(split_res[3], axis=2)
concat_list = [split_res0, split_res[1], split_res2, split_res3]
out = _sym.concatenate(*concat_list, axis=2)
return _sym.reshape(out, shape=input_shape), None
tqchen
added
status: need update
|
@siju-samuel please act on the comments |
8 tasks
tqchen
approved these changes
Feb 27, 2019
tqchen
added
status: accepted
and removed
status: need update
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
regionop is used only in darknet and since its not generic and can be acheived by frontend itself, i implemented the op indarknet.pyand removed all the existing region_op registration, testcases and topi code.This will be helpful when migrating to
relayas from relay,regionop is not added.Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.