[Relay] GNF #2492
[Relay] GNF #2492
Conversation
|
@srkreddy1238 @vinx13 @yzhliu can you guys help review? Thx! |
|
If recursion is a corner case, can you have a recursive test case? |
|
@slyubomirsky recursion need pass manager. i will add it once it get in. |
|
What would the pass manager be needed to do? |
|
pass manager will apply a pass into a golbalvar. somehow fuse_ops cant handle recursion without it. |
tests/python/relay/test_to_gnf.py
Outdated
| from tvm.relay.backend.interpreter import Value, TupleValue | ||
|
|
||
|
|
||
| def check_eval(expr, args, expected_result, mod=None, rtol=1e-07): |
There was a problem hiding this comment.
write test cases that does ANF -> GNF roundtrip
There was a problem hiding this comment.
Get an existing neural network, run ToANF, and then ToGraphNormalForm and check consistency
There was a problem hiding this comment.
is it necessary to do an nn? i get a simpler test working
|
Followup comment: to make API consistent, maybe we should rename to_anf to to_a_normal_form |
|
@tqchen can you review? sorry for the inconvenience. |
tqchen
added
status: accepted
and removed
status: need review
status: need update
This PR will do the exact reverse of ANF conversion - it take any code using let, and will attempt to remove the let by reusing the same expr.
The only nontrivial case is recursion - we keep let in such case to avoid forming loop.