-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TVM][BUGFIX] Fix missing reduction init predicates #2495
Merged
ZihengJiang
merged 3 commits into
apache:master
from
sgrechanik-h:pr-reduction-init-cond-pred-fix
Feb 6, 2019
Merged
[TVM][BUGFIX] Fix missing reduction init predicates #2495
ZihengJiang
merged 3 commits into
apache:master
from
sgrechanik-h:pr-reduction-init-cond-pred-fix
Feb 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZihengJiang
reviewed
Jan 31, 2019
std::unordered_set<IterVar> skip_iter; | ||
for (auto kv : update_state) { | ||
int flag = kv.second; | ||
if ((flag & 1) == 0) skip_iter.insert(kv.first); | ||
if ((flag & 2) != 0) skip_iter.insert(kv.first); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not flag == 2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, this actually should be flag == 2
. Added a test case for this.
ZihengJiang
approved these changes
Feb 6, 2019
This was referenced Feb 15, 2019
Closed
Closed
Closed
libing4752
pushed a commit
to libing4752/tvm
that referenced
this pull request
Feb 18, 2019
* [TVM][BUGFIX] Fix reductions in split axes * A test case for the problem * Fix the fix: skip loops that are related to reduction AND are unrelated to axis
merrymercy
pushed a commit
to merrymercy/tvm
that referenced
this pull request
Feb 18, 2019
* [TVM][BUGFIX] Fix reductions in split axes * A test case for the problem * Fix the fix: skip loops that are related to reduction AND are unrelated to axis
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
* [TVM][BUGFIX] Fix reductions in split axes * A test case for the problem * Fix the fix: skip loops that are related to reduction AND are unrelated to axis
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
* [TVM][BUGFIX] Fix reductions in split axes * A test case for the problem * Fix the fix: skip loops that are related to reduction AND are unrelated to axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 6fdc3e0 triggered the following bug. Consider this code:
Before 6fdc3e0 the generated code looked like this:
After 6fdc3e0 the code looks like this:
which is wrong, the result gets reset to zero. The reason is that the initialization is not guarded by the condition
singleton.outer < 1
.The fix I propose is to skip loops related to the reduction axes instead of skipping loops unrelated to the compute op axes when generating predicates for the initialization code. The result now looks like this:
@tqchen @derisavi Please take a look.