Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVM][BUGFIX] Fix missing reduction init predicates #2495

Merged

Conversation

sgrechanik-h
Copy link
Contributor

@sgrechanik-h sgrechanik-h commented Jan 23, 2019

The commit 6fdc3e0 triggered the following bug. Consider this code:

    n = 10
    X = tvm.placeholder(shape=(10,), dtype='int32', name="X")
    k = tvm.reduce_axis((0, n))
    Y = tvm.compute((), lambda: tvm.sum(X[k], k), name="Y")

    s = tvm.create_schedule([Y.op])
    ax = s[Y.op].fuse(*Y.op.axis)
    axo, axi = s[Y.op].split(ax, nparts=20)

    print(tvm.lower(s, [Y, X], simple_mode=True))

Before 6fdc3e0 the generated code looked like this:

produce Y {
  for (singleton.outer, 0, 20) {
    Y[0] = 0
    for (rv, 0, 10) {
      Y[0] = (Y[0] + X[rv])
    }
  }
}

After 6fdc3e0 the code looks like this:

produce Y {
  for (singleton.outer, 0, 20) {
    Y[0] = 0
    for (rv, 0, 10) {
      if (likely((singleton.outer < 1))) {
        Y[0] = (Y[0] + X[rv])
      }
    }
  }
}

which is wrong, the result gets reset to zero. The reason is that the initialization is not guarded by the condition singleton.outer < 1.

The fix I propose is to skip loops related to the reduction axes instead of skipping loops unrelated to the compute op axes when generating predicates for the initialization code. The result now looks like this:

produce Y {
  for (singleton.outer, 0, 20) {
    if (likely((singleton.outer < 1))) {
      Y[0] = 0
    }
    for (rv, 0, 10) {
      if (likely((singleton.outer < 1))) {
        Y[0] = (Y[0] + X[rv])
      }
    }
  }
}

@tqchen @derisavi Please take a look.

std::unordered_set<IterVar> skip_iter;
for (auto kv : update_state) {
int flag = kv.second;
if ((flag & 1) == 0) skip_iter.insert(kv.first);
if ((flag & 2) != 0) skip_iter.insert(kv.first);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not flag == 2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this actually should be flag == 2. Added a test case for this.

@ZihengJiang ZihengJiang merged commit f0ae8e3 into apache:master Feb 6, 2019
libing4752 pushed a commit to libing4752/tvm that referenced this pull request Feb 18, 2019
* [TVM][BUGFIX] Fix reductions in split axes

* A test case for the problem

* Fix the fix: skip loops that are related to reduction AND are unrelated to axis
merrymercy pushed a commit to merrymercy/tvm that referenced this pull request Feb 18, 2019
* [TVM][BUGFIX] Fix reductions in split axes

* A test case for the problem

* Fix the fix: skip loops that are related to reduction AND are unrelated to axis
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
* [TVM][BUGFIX] Fix reductions in split axes

* A test case for the problem

* Fix the fix: skip loops that are related to reduction AND are unrelated to axis
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
* [TVM][BUGFIX] Fix reductions in split axes

* A test case for the problem

* Fix the fix: skip loops that are related to reduction AND are unrelated to axis
@yzhliu yzhliu mentioned this pull request Mar 2, 2019
28 tasks
@sgrechanik-h sgrechanik-h deleted the pr-reduction-init-cond-pred-fix branch November 3, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants