-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Update rust format version #2550
Conversation
You are right! Thanks for the update. The docker install rustfmt version must match exactly with the version used in |
This is a giant problem with rustfmt. Fortunately we've finally made it to stable nightly (whatever that means) so it'll be quite a while before we update again. At most in 3 years when rust releases another edition. |
@nhynes can u comment on http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-2550/3/pipeline? If there is a quick fix to this problem |
@tqchen That's a new rustfmt rule. Please change make those #![allow(...)] in
I verified it locally on
that should be fixed in frontend merge. |
Hopefully as Nick said, we won't get headache after this. The lesson was such changes should be verified independent from current docker setup then commit the changes all at once in docker and rustfmt config. |
OK, I temporarily disabled the rust test in |
cc @nhynes @ehsanmok
The update the rust docker creates outrage in the CI because of version mismatch. Next time, we might need to consider a safe transition rule(e.g. remove test or relax version for now)