Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELAY][OP] ROI Align #2618

Merged
merged 1 commit into from
Feb 20, 2019
Merged

[RELAY][OP] ROI Align #2618

merged 1 commit into from
Feb 20, 2019

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Feb 18, 2019

The API arguments follow MXNet one. Caffe / Pytorch have similar API but they don't use sample_ratio
argument (we can use the default value). TF doesn't have ROI Align (it uses crop_and_resize + pooling instead)

please review @kevinthesun @Laurawly @masahi

@vinx13 vinx13 force-pushed the feature/roi_align_op branch from 19700d9 to 49b95b9 Compare February 18, 2019 08:43
Copy link
Contributor

@Laurawly Laurawly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masahi masahi merged commit 8b1d07f into apache:master Feb 20, 2019
@masahi
Copy link
Member

masahi commented Feb 20, 2019

thanks @vinx13 @Laurawly this is merged.

wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
@yzhliu yzhliu mentioned this pull request Mar 2, 2019
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants