[Relay] Ensure nested higher-order functions are treated correctly #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Feb 27, 2019
|
Thanks, @slyubomirsky this is merged, please request reviewers next time |
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue that @MarisaKirisame brought to my attention (and indeed, resulted in a TODO in code that was merged into mainline). Namely, if a higher-order function (e.g., a polymorphic
idfunction) were nested inside another function, it could cause type-checking to fail because Relay presently only supports polymorphism at the top level.This PR attempts to solve that problem by instantiating any nested polymorphic types whenever they occur in type inference. As it happens, doing this inside
Unify()in the type checker handles almost all cases, though I would appreciate any review as to whether there may be missing cases. (Or suggestions as to what might be a less clumsy approach to this problem.)