[AUTOTVM] tweak sample_int implementation
#2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
requested changes
Feb 27, 2019
python/tvm/autotvm/util.py
Outdated
| @@ -58,10 +60,11 @@ def sample_ints(low, high, m): | |||
| """ | |||
| vis = set() | |||
| assert m <= high - low | |||
| print("hi fam") | |||
python/tvm/autotvm/util.py
Outdated
| @@ -40,7 +42,7 @@ def get_rank(values): | |||
| def sample_ints(low, high, m): | |||
| """ | |||
| Sample m different integer numbers from [low, high) without replacement | |||
| This function is an alternative of `np.random.choice` when (high - low) > 2 ^ 32, in | |||
| This function is an alternative of `np.random.choice` when (high - low) > 2 ^ 64, in | |||
There was a problem hiding this comment.
We don't need to modify this line., because the np.random.choice does not work when (high - low) > 2^32, and this comment still holds.
merrymercy
approved these changes
Feb 28, 2019
bwasti
pushed a commit
to facebookexperimental/tvm
that referenced
this pull request
Mar 6, 2019
* check in * lint * cleanup * Update util.py
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
* check in * lint * cleanup * Update util.py
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* check in * lint * cleanup * Update util.py
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* check in * lint * cleanup * Update util.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample_intseems to have issues with high-low > 2^32, even in Python 3. Switching torandomseems to work.CC @merrymercy