Improve task_lint.sh robustness #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up the use of grep. Use -E rather than run multiple grep instances.
Prefer to use stdin redirection rather than create a pipeline.
Place temporary files in the conventional /tmp location. Avoid poisoning file name space by using $$. Ensure the temporary files get cleaned up, even when the script fails / exits early.
Ensure script failures are caught and propagated. Rather than trying to explicitly catch and propagate failures with explicit "|| exit" annotations, use the "set -e" idom from docker/install scripts and have the shell catch and propagate errors in the general case and special case the grep instances where non zero exit is permitted and should be ignored.
tqchen
approved these changes
Mar 1, 2019
|
Thanks, @mjs-arm , this is now merged |
bwasti
pushed a commit
to facebookexperimental/tvm
that referenced
this pull request
Mar 6, 2019
* [SCRIPT] Refactor grep for multiple patterns Tidy up the use of grep. Use -E rather than run multiple grep instances. * [SCRIPT] Refactor grep use in pipeline. Prefer to use stdin redirection rather than create a pipeline. * [SCRIPT] Refactor placement and cleanup of temporary files. Place temporary files in the conventional /tmp location. Avoid poisoning file name space by using $$. Ensure the temporary files get cleaned up, even when the script fails / exits early. * [SCRIPT] Improve robustness of task_lint.sh error handling. Ensure script failures are caught and propagated. Rather than trying to explicitly catch and propagate failures with explicit "|| exit" annotations, use the "set -e" idom from docker/install scripts and have the shell catch and propagate errors in the general case and special case the grep instances where non zero exit is permitted and should be ignored.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 9, 2019
* [SCRIPT] Refactor grep for multiple patterns Tidy up the use of grep. Use -E rather than run multiple grep instances. * [SCRIPT] Refactor grep use in pipeline. Prefer to use stdin redirection rather than create a pipeline. * [SCRIPT] Refactor placement and cleanup of temporary files. Place temporary files in the conventional /tmp location. Avoid poisoning file name space by using $$. Ensure the temporary files get cleaned up, even when the script fails / exits early. * [SCRIPT] Improve robustness of task_lint.sh error handling. Ensure script failures are caught and propagated. Rather than trying to explicitly catch and propagate failures with explicit "|| exit" annotations, use the "set -e" idom from docker/install scripts and have the shell catch and propagate errors in the general case and special case the grep instances where non zero exit is permitted and should be ignored.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* [SCRIPT] Refactor grep for multiple patterns Tidy up the use of grep. Use -E rather than run multiple grep instances. * [SCRIPT] Refactor grep use in pipeline. Prefer to use stdin redirection rather than create a pipeline. * [SCRIPT] Refactor placement and cleanup of temporary files. Place temporary files in the conventional /tmp location. Avoid poisoning file name space by using $$. Ensure the temporary files get cleaned up, even when the script fails / exits early. * [SCRIPT] Improve robustness of task_lint.sh error handling. Ensure script failures are caught and propagated. Rather than trying to explicitly catch and propagate failures with explicit "|| exit" annotations, use the "set -e" idom from docker/install scripts and have the shell catch and propagate errors in the general case and special case the grep instances where non zero exit is permitted and should be ignored.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 12, 2019
* [SCRIPT] Refactor grep for multiple patterns Tidy up the use of grep. Use -E rather than run multiple grep instances. * [SCRIPT] Refactor grep use in pipeline. Prefer to use stdin redirection rather than create a pipeline. * [SCRIPT] Refactor placement and cleanup of temporary files. Place temporary files in the conventional /tmp location. Avoid poisoning file name space by using $$. Ensure the temporary files get cleaned up, even when the script fails / exits early. * [SCRIPT] Improve robustness of task_lint.sh error handling. Ensure script failures are caught and propagated. Rather than trying to explicitly catch and propagate failures with explicit "|| exit" annotations, use the "set -e" idom from docker/install scripts and have the shell catch and propagate errors in the general case and special case the grep instances where non zero exit is permitted and should be ignored.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.