-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay] Add logical operators #2743
Conversation
Per Tianqi's point below, consistency with existing logical ops is better |
See https://docs.tvm.ai/langref/relay_op.html for support level explaination. I think it should be level 4 |
@abergeron look good to me. Update the support_level as per @tqchen advice. Also update the support_level for NNVM too. |
Should it be defined using RELAY_REGISTER_BINARY_OP? It mean it work on any dtype. |
I've fixed the support level. I don't think those operators are applicable for all types, but I don't know how to limit the types. |
Thanks, @MarisaKirisame @abergeron @srkreddy1238 @slyubomirsky , this is now merged. We could use a followup PR to update type relation to assert bool types, but since it is not strictly necessary, we can go with the current ver for now |
@abergeron please send a followup to update https://docs.tvm.ai/langref/relay_op.html |
@tqchen I can do it, but I have tons of task next week. I will open a issue. If noone does it next week I will pick it up, does it sound good? |
@MarisaKirisame Sounds good, go ahead and open an issue |
This is a follow-up to #2453, to port the operators that were added to Relay.
The one thing I'm less than certain about is the support_level since I've yet to see some actual documentation about what it means.