[Relay] Improved multiply_rewrite for gluoncv_ssd quantization
#2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
reviewed
Mar 19, 2019
| @@ -166,7 +166,7 @@ def multiply_rewrite(ref_call, new_args, ctx): | |||
|
|
|||
| if lhs_kind is None and rhs_kind is None: | |||
| return None | |||
| if lhs_kind == QAnnotateKind.ACTIVATION and rhs_kind is None: | |||
| if lhs_kind in [QAnnotateKind.ACTIVATION, QAnnotateKind.INPUT] and rhs_kind is None: | |||
There was a problem hiding this comment.
add a check to attach_simulated_quantize below to prevent quantizing lhs to INPUT if lhs_kind is INPUT
There was a problem hiding this comment.
I'm not quite familiar with this, but what shall lhs_expr be if lhs_kind is INPUT?
There was a problem hiding this comment.
it is the same from input, new_args[0]
There was a problem hiding this comment.
okay, i will revise accordingly.
…lhs to INPUT if lhs_kind is INPUT;
vinx13
approved these changes
Mar 20, 2019
liangfu
changed the title
multiply_rewrite for gluoncv_ssd quantizationmultiply_rewrite for gluoncv_ssd quantization
tqchen
approved these changes
Mar 20, 2019
Laurawly
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Mar 22, 2019
…che#2848) * improved `multiply_rewrite` for gluoncv_ssd quantization * add a check to attach_simulated_quantize below to prevent quantizing lhs to INPUT if lhs_kind is INPUT;
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Mar 24, 2019
…che#2848) * improved `multiply_rewrite` for gluoncv_ssd quantization * add a check to attach_simulated_quantize below to prevent quantizing lhs to INPUT if lhs_kind is INPUT;
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 24, 2019
…che#2848) * improved `multiply_rewrite` for gluoncv_ssd quantization * add a check to attach_simulated_quantize below to prevent quantizing lhs to INPUT if lhs_kind is INPUT;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZihengJiang @vinx13 please review.