Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schedule_dataflow_rewrite.cc #2934

Merged
merged 2 commits into from
Apr 1, 2019
Merged

Update schedule_dataflow_rewrite.cc #2934

merged 2 commits into from
Apr 1, 2019

Conversation

Youjk
Copy link
Contributor

@Youjk Youjk commented Mar 31, 2019

a bug about compute_inline. the details see #2912

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

a bug about compute_inline.  the details see apache#2912
@tqchen
Copy link
Member

tqchen commented Mar 31, 2019

Thanks for the contribution, please add a regression test case to prevent it from happening again https://docs.tvm.ai/contribute/code_review.html#ensure-test-coverage

@tqchen tqchen added the status: need test case need test cases to cover the change label Mar 31, 2019
add testcase for schedule_ops about compute_inline
@Youjk
Copy link
Contributor Author

Youjk commented Apr 1, 2019

Thanks for the contribution, please add a regression test case to prevent it from happening again https://docs.tvm.ai/contribute/code_review.html#ensure-test-coverage

thanks, testcase Done

@tqchen tqchen merged commit bbaee69 into apache:master Apr 1, 2019
@tqchen tqchen added status: accepted and removed status: need test case need test cases to cover the change labels Apr 1, 2019
@tqchen
Copy link
Member

tqchen commented Apr 1, 2019

Thanks @Youjk , this is now merged

wweic pushed a commit to wweic/tvm that referenced this pull request Apr 7, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 7, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 8, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Apr 10, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants