1) fixes in loop partitioning algorithm 2) added a testcase #2956
Conversation
derisavi
force-pushed
the
loop-partition
branch
2 times, most recently
from
e67dbcc
to
5c5bdf9
Compare
|
@derisavi please also tag more reviewers |
|
@anijain2305 @MarisaKirisame @xqdan @yzhliu Please review. Thanks. |
To be clear, the code before my change did handle multiple vars in the same condition. My change fixes other problems (e.g., in some cases we didn't recursively partition pre- or post-subranges, and we didn't partition based on when conditions are false). |
derisavi
force-pushed
the
loop-partition
branch
from
5c5bdf9
to
d2cfa36
Compare
| arith::Interval interval = kv.second.as<arith::IntervalSet>()->i; | ||
| auto intersection = arith::Interval::make_intersection(interval, for_interval); | ||
|
|
||
| // TODO(derisavi): the following if statement needs to be removed as soon as |
There was a problem hiding this comment.
should this be removed?
There was a problem hiding this comment.
Not yet. The commit of HalideIR currently used in master branch of tvm is 55ba177 which is older than a768f2f0 that is required to remove that if statement.
There was a problem hiding this comment.
can you update the submodule then remove here?
There was a problem hiding this comment.
I tried to pick latest commit in HalideIR but apparently because of this commit (dmlc/HalideIR@92ef20f) , TVM source code compilation gives an error. I once tried to fix this compile problem but it wasn't trivial and required understanding the code change in HalideIR. (@jroesch can you please take a look and help us out?)
So we can either 1) wait for this compile problem to be fixed, perform the TODO, and then merge this PR or 2) merge this PR, wait for the compile problem to be fixed and then perform the TODO? I'm open to both but I prefer (2).
There was a problem hiding this comment.
@derisavi Okay, let us merge the PR for now
There was a problem hiding this comment.
@derisavi Could you try other commit like HEAD~1 besides the head
There was a problem hiding this comment.
The change I need is at HEAD and the problematic commit is HEAD~1 and TVM is currently using HEAD~2. So trying HEAD~1 wouldn't resolve the problem.
There was a problem hiding this comment.
I rebased/squashed and pushed with the TODO item still in the code.
derisavi
force-pushed
the
loop-partition
branch
from
d2cfa36
to
3772dd5
Compare
…sed when double splitting with indivisible factors 2) added a testcase
derisavi
force-pushed
the
loop-partition
branch
from
3772dd5
to
5c45b37
Compare
|
Thanks @derisavi , this is merged |
…sed when double splitting with indivisible factors 2) added a testcase (apache#2956)
…sed when double splitting with indivisible factors 2) added a testcase (apache#2956)
This fixes #2898. The main changes are:
I did my best to keep the changes as small as possible, i.e., if we remove the code for any of the changes above, we won't generate correct code.
@tqchen @ZihengJiang please review.