[Relay] [Bugfix] make LetList.h insert empty Type instead of IncompleteType #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wweic
requested changes
Apr 8, 2019
|
It doesnt break tvm in anyway. It is just the right thing to do (according to IncompleteType), and it give better error message. |
wweic
approved these changes
Apr 8, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Apr 10, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.
@ZihengJiang @jroesch @srkreddy1238 @wweic @icemelon9 can you guys review?