-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUST][FRONTEND] Fix resnet example #3000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhynes
suggested changes
Apr 10, 2019
Let us try to directly use tvm.testing, which will also give you a resnet with random inputs |
nhynes
reviewed
Apr 13, 2019
Uncomment python build logs Address review comments Idiomatic to_vec for TVMByteArray Enable resnet with random weights for testing Fix mxnet import Python3 build only
@nhynes it's ready now! how good is the 3000th PR. Let's aim at the 9000th! |
nhynes
approved these changes
Apr 15, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
Due to the previous changes the frontend resnet example failed to build. So this patch 1) fixes it 2) adds ~~a local `run_tests.sh` to remedy non-existence of MXNet CI (used in python build example)~~ the example build to CI with random weights and a flag for pretrained resnet weights Please review: @tqchen @nhynes @kazimuth
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
Due to the previous changes the frontend resnet example failed to build. So this patch 1) fixes it 2) adds ~~a local `run_tests.sh` to remedy non-existence of MXNet CI (used in python build example)~~ the example build to CI with random weights and a flag for pretrained resnet weights Please review: @tqchen @nhynes @kazimuth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the previous changes the frontend resnet example failed to build. So this patch
a localthe example build to CI with random weights and a flag for pretrained resnet weightsrun_tests.sh
to remedy non-existence of MXNet CI (used in python build example)Please review: @tqchen @nhynes @kazimuth