Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUST][FRONTEND] Fix resnet example #3000

Merged
merged 1 commit into from
Apr 15, 2019
Merged

[RUST][FRONTEND] Fix resnet example #3000

merged 1 commit into from
Apr 15, 2019

Conversation

ehsanmok
Copy link
Contributor

@ehsanmok ehsanmok commented Apr 10, 2019

Due to the previous changes the frontend resnet example failed to build. So this patch

  1. fixes it
  2. adds a local run_tests.sh to remedy non-existence of MXNet CI (used in python build example) the example build to CI with random weights and a flag for pretrained resnet weights

Please review: @tqchen @nhynes @kazimuth

rust/frontend/src/lib.rs Show resolved Hide resolved
rust/run_tests.sh Outdated Show resolved Hide resolved
rust/common/src/value.rs Outdated Show resolved Hide resolved
rust/common/src/value.rs Outdated Show resolved Hide resolved
rust/common/src/value.rs Show resolved Hide resolved
@ehsanmok
Copy link
Contributor Author

@tqchen @nhynes here's the situation again. I need to include resnet example build in CI but since we do not have MXNet install then I cannot. Any suggestions what to do?

@tqchen
Copy link
Member

tqchen commented Apr 13, 2019

Let us try to directly use tvm.testing, which will also give you a resnet with random inputs

rust/common/src/value.rs Outdated Show resolved Hide resolved
Uncomment python build logs

Address review comments

Idiomatic to_vec for TVMByteArray

Enable resnet with random weights for testing

Fix mxnet import

Python3 build only
@ehsanmok
Copy link
Contributor Author

@nhynes it's ready now! how good is the 3000th PR. Let's aim at the 9000th!

@nhynes nhynes merged commit 8d3b392 into apache:master Apr 15, 2019
@ehsanmok ehsanmok deleted the frontend_example_fix branch April 18, 2019 17:52
wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
Due to the previous changes the frontend resnet example failed to build.  So this patch 

1) fixes it 
2) adds ~~a local `run_tests.sh` to remedy non-existence of MXNet CI (used in python build example)~~ the example build to CI with random weights and a flag for pretrained resnet weights

Please review: @tqchen @nhynes @kazimuth
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
Due to the previous changes the frontend resnet example failed to build.  So this patch 

1) fixes it 
2) adds ~~a local `run_tests.sh` to remedy non-existence of MXNet CI (used in python build example)~~ the example build to CI with random weights and a flag for pretrained resnet weights

Please review: @tqchen @nhynes @kazimuth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants