Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] Add printing for ADT Type #3030

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Conversation

MarisaKirisame
Copy link
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@MarisaKirisame MarisaKirisame changed the title [Relay] Add parsing for ADT [Relay] Add parsing for ADT Type Apr 16, 2019
@MarisaKirisame
Copy link
Contributor Author

@joshpoll @weberlo @icemelon9 can you guys review?

@wweic
Copy link
Contributor

wweic commented Apr 16, 2019

This is printing, not parsing(in the title)?

@MarisaKirisame MarisaKirisame changed the title [Relay] Add parsing for ADT Type [Relay] Add printing for ADT Type Apr 16, 2019
@MarisaKirisame
Copy link
Contributor Author

@wweic sorry, i am sleepy.

@weberlo
Copy link
Contributor

weberlo commented Apr 16, 2019

looks good to me

Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@icemelon icemelon self-assigned this Apr 17, 2019
@icemelon icemelon merged commit 4ab97df into apache:master Apr 17, 2019
@icemelon
Copy link
Member

Thanks everyone. This is now merged.

larroy pushed a commit to larroy/tvm that referenced this pull request Apr 19, 2019
* Update pretty_printer.cc

* Update pretty_printer.cc
wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
* Update pretty_printer.cc

* Update pretty_printer.cc
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
* Update pretty_printer.cc

* Update pretty_printer.cc
@MarisaKirisame MarisaKirisame deleted the patch-3 branch July 13, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants