[Relay][Ops] Register all operators' attributes in Python #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sily accessed from Python code
2 tasks
|
Please review if you can @wweic (suggested I make this a separate PR), @merrymercy (previously modified the file), @jroesch |
|
Thanks, @slyubomirsky @wweic, this PR is now merged |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
…sily accessed from Python code (apache#3175)
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
…sily accessed from Python code (apache#3175)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing Relay operator calls in Python, unless the attributes node for that operator is specifically registered, the attributes nodes are treated as
tvm.NodeBaseand thus it is impossible to list and access the keys for those attributes. That makes it incredibly difficult to programmatically manipulate operator calls in Python.It may also be wise to update the operator registration instructions to also encourage registering the attributes node for that operator, as in here.