[BugFix][VTA] Fix bug in vta runtime DepPop function. #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmoreau89 could you help to review this patch? Thanks |
Issue:
One of existing illegal dependency check's condition always true,
the correct logic actually should be such check for store and load.
Solution:
Fix the said logic issue.
tqchen
approved these changes
May 20, 2019
|
Thanks, @huajsj , this is now merged |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
Issue:
One of existing illegal dependency check's condition always true,
the correct logic actually should be such check for store and load.
Solution:
Fix the said logic issue.
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Issue:
One of existing illegal dependency check's condition always true,
the correct logic actually should be such check for store and load.
Solution:
Fix the said logic issue.
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Mar 29, 2020
Issue:
One of existing illegal dependency check's condition always true,
the correct logic actually should be such check for store and load.
Solution:
Fix the said logic issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
One of existing dependency check used a always true condition,
and the intend logic actually should be a check for such illegal
scenario of store and load.
Solution:
Fix the said logic issue.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.