New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[relay][vm] remove throw in destructor #3215

Merged

jroesch merged 1 commit into apache:master from zhiics:fix

May 21, 2019

Member

zhiics commented May 21, 2019 •

edited

Loading

throw shouldn't be used in the destructor, just log fatal directly.

cc @jroesch @tqchen @icemelon9 @wweic


          [relay][vm] remove throw in destructor

f719a0f

wweic approved these changes

View reviewed changes

jroesch approved these changes

View reviewed changes

jroesch merged commit 91b181d into apache:master

zhiics deleted the fix branch

May 21, 2019 19:58

wweic pushed a commit to wweic/tvm that referenced this pull request


          [relay][vm] remove throw in destructor (apache#3215)

04d2b04

wweic pushed a commit to neo-ai/tvm that referenced this pull request


          [relay][vm] remove throw in destructor (apache#3215)

f0011fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet