[TOPI] Add ops compute #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most declaration function are supposed to be used directly used by the user, following same convention as numpy and mxnet/pytorch/tf style. Remove compute prefix from them |
tqchen
reviewed
Aug 14, 2017
topi/python/topi/nn/softmax.py
Outdated
| import tvm | ||
|
|
||
| @tvm.tag_scope(tag='softmax') | ||
| def softmax_output(x): |
tqchen
reviewed
Aug 14, 2017
topi/python/topi/nn/softmax.py
Outdated
| assert len(x.shape) == 2, "only support 2-dim softmax" | ||
| M, N = x.shape | ||
| k = tvm.reduce_axis((0, N), name='k') | ||
| expsum = tvm.compute((M, ), lambda i: \ |
There was a problem hiding this comment.
This softmax is not numerically stable. To make things numerically stable, need to substract the maximum value along the columns first
tqchen
requested changes
Aug 15, 2017
|
|
||
| Returns | ||
| ------- | ||
| output : tvm.Tensor |
There was a problem hiding this comment.
There should be three output arguments, according to what get returned
tqchen
reviewed
Aug 15, 2017
| dheight = tvm.reduce_axis((0, kernel_height)) | ||
| dwidth = tvm.reduce_axis((0, kernel_width)) | ||
|
|
||
| temp = tvm.compute((batch, channel, padded_height, padded_width), lambda i, c, h, w: \ |
Remove 'compute' and add assert for safety Add document fix lint fix softmax
tqchen
approved these changes
Aug 15, 2017
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
May 26, 2018
…he#323) * Explain how to generate module library * Small fix
tqchen
pushed a commit
that referenced
this pull request
May 29, 2018
* Explain how to generate module library * Small fix
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
…he#323) * Explain how to generate module library * Small fix
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
…he#323) * Explain how to generate module library * Small fix
vinx13
pushed a commit
to vinx13/tvm
that referenced
this pull request
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.