Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to fix issue Target llvm is not enabled #3403

Closed
wants to merge 1 commit into from

Conversation

henrywu2019
Copy link
Contributor

Issue:
I was building TVM4J and got error bf != nullptr Target llvm is not enabled when generating shared library. The issue is similar to #1020

Solution:
enable LLVM in config.cmake

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@FrozenGene
Copy link
Member

FrozenGene commented Jun 20, 2019

I think we shouldn't do this change. As the comment said:

/path/to/llvm-config: enable specific LLVM when multiple llvm-dev is available.

We should let the user specify the correct path. The doc also said what the condition and how to turn it on:
https://docs.tvm.ai/install/from_source.html Users should read the manual carefully firstly.

Meanwhile, when we compile the runtime only, we don't need LLVM on. So TVM just depend on LLVM optionally.

@henrywu2019
Copy link
Contributor Author

henrywu2019 commented Jun 20, 2019

I see. Maybe a better way is to put it explicitly in TVM4J's README saying we need to turn on LLVM support for TVM4J? It will help beginners to save a lot of time to troubleshooting, won't it?

@FrozenGene
Copy link
Member

I see. Maybe a better way is to put it explicitly in TVM4J's README saying we need to turn on LLVM support for TVM4J? It will help beginners to save a lot of time to troubleshooting, won't it?

The TVM4J Readme in fact have listed the doc I mention before:
image

However, I think you could PR the TVM4J readme and emphasize users should notice turning LLVM on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants