[VTA] [Chisel] Added Test Infrastructure #3682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminTu
changed the title
|
Hey @BenjaminTu I think you are adding to |
BenjaminTu
changed the title
|
Removed! These are files that are generated by the testing script, each test will have their own |
vegaluisjose
requested changes
Jul 31, 2019
vegaluisjose
requested changes
Jul 31, 2019
vegaluisjose
requested changes
Jul 31, 2019
There was a problem hiding this comment.
Let's add some comments/docs. You could use other modules (classes) as reference. For example, see here
|
added some comments on |
vegaluisjose
requested changes
Jul 31, 2019
vegaluisjose
requested changes
Aug 1, 2019
vegaluisjose
approved these changes
Aug 1, 2019
liangfu
requested changes
Aug 1, 2019
This side effect at module import time has a race condition between the "exists" check and the "mkdir" call. The safer thing is to just call mkdir and catch the "already exists" error which is what makedirs does.
Fix typo names in caffe2 and onnx frontend: * sotrage_order -> storage_order * OpNotInplemented -> OpNotImplemented
* add fatal lint lint lint do make completeness check an error lint remove fatal * fix test * reset parser file * remove unneeded import * Update python/tvm/relay/adt.py Co-Authored-By: Steven S. Lyubomirsky <slyubomirsky@gmail.com> * Update include/tvm/relay/adt.h Co-Authored-By: Steven S. Lyubomirsky <slyubomirsky@gmail.com> * Eliminate trailing whitespace (my fault)
The patch adds support for Tensorflow operators log1p and cos Tensorflow log1p is described at https://www.tensorflow.org/api_docs/python/tf/math/log1p Tensorflow cos is described at https://www.tensorflow.org/api_docs/python/tf/math/cos Tensorflow sin is described at https://www.tensorflow.org/api_docs/python/tf/math/sin
* [Relay][Quantization] Support floating-point scale * [Relay][Quantization] KL-divergence calibration on dataset * Fix unhandled LeftShift case in QuantizeRealize * Fix lint * drop QBias * fix lint * address comments * address comments * Update comments * address comments * lint * kQIdentity = 0
* [TOPI] Memoize winograd matrix * lint * Fix name
* add dgl to docker file * add dgl to docker file
* [AutoTVM] Fix hang/crash issues on feature extraction * Update xgboost_cost_model.py * fix lint
tmoreau89
reviewed
Aug 2, 2019
There was a problem hiding this comment.
Good to see a unit test infrastructure @BenjaminTu ! Can you perhaps add a few lines in a README.md on how to run, and extend the unit tests if others want to contribute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.