-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoTVM] Fix database APIs #3821
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@icemelon9 please help review and merge. |
wweic
requested changes
Aug 23, 2019
@wweic thanks for review. Please see my comments and new commits. |
wweic
approved these changes
Aug 28, 2019
icemelon
approved these changes
Aug 28, 2019
icemelon
added
status: accepted
and removed
status: need update
need update based on feedbacks
labels
Aug 28, 2019
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
* [AutoTVM] Fix database APIs * Refactor the byte conversion
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
* [AutoTVM] Fix database APIs * Refactor the byte conversion
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 16, 2019
* [AutoTVM] Fix database APIs * Refactor the byte conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database APIs designed in AutoTVM will throw exceptions with Redis database in Python 3. The main reason is that Python 3 package
redis
returns values inbytes
format instead ofstr
so it cannot be manipulated by builtin string methods likesplit
.The original code uses
str(result)
to convertbytes
tostr
, but this is not the right way:As can be seen,
str
simply invokesbytes.__str__()
and results in unnecessaryb\'...\'
characters. The right way to do so is usingdecode
method:This PR fixes the issue and creates a new unit test to cover
filer
method which wasn't covered before. With the changes, the unit test passes for bothDummyDatabase
andRedisDatabase
locally.One remain issue could be the lack of unit tests for Redis database, but this requires changes of CI environment.