Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Fixes "common" sub crate using nightly and master #3965

Merged
merged 4 commits into from
Sep 22, 2019
Merged

[Rust] Fixes "common" sub crate using nightly and master #3965

merged 4 commits into from
Sep 22, 2019

Conversation

paddyhoran
Copy link
Contributor

Fixes 3964.

Also, removes warning for stabilized feature type_alias_enum_variants

@paddyhoran
Copy link
Contributor Author

cc @nhynes

@nhynes nhynes self-requested a review September 17, 2019 18:32
nhynes
nhynes approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@nhynes nhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is it now possible to re-enable Rust in CI? I can take a look at that if you'd rather not.

@paddyhoran
Copy link
Contributor Author

I hope so. I'd like to add support for windows and was hoping to get CI up for it eventually. I'll try and take a look. Where is it currently disabled?

I see Azure Pipelines running but where are the jobs defined?

@tqchen
Copy link
Member

tqchen commented Sep 20, 2019

@nhynes please feel free to merge it in :) We can send another pr to reenable rust ci

@nhynes nhynes merged commit cb1faf8 into apache:master Sep 22, 2019
@tqchen
Copy link
Member

tqchen commented Sep 23, 2019 •
edited
Loading

@nhynes can you send a followup PR to renable rust-ci?

@nhynes
Copy link
Member

nhynes commented Sep 23, 2019

followup PR to renable rust-ci?

There's a linking issue that's been resolved in #2885. I'll re-enable Rust CI once that lands.

@paddyhoran
Copy link
Contributor Author

@nhynes @tqchen it looks like there might an issue with this, see here.

I'm thinking the types generated by bindgen are platform specific(I'm on windows), but I need to confirm.

@paddyhoran paddyhoran deleted the nightly-fixes branch September 26, 2019 19:31
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
@paddyhoran @wweic
[Rust] Fixes "common" sub crate using nightly and master (apache#3965)
1f706b2
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
@paddyhoran @wweic
[Rust] Fixes "common" sub crate using nightly and master (apache#3965)
5b876cb
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 1, 2019
@paddyhoran @wweic
[Rust] Fixes "common" sub crate using nightly and master (apache#3965)
65b3ca0
@yzhliu yzhliu mentioned this pull request Nov 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhynes nhynes nhynes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rust] "Common" sub-crate does not build on latest nightly and master
3 participants
@paddyhoran @tqchen @nhynes