Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Compile_engine] Int64 shape handling for outputs. #4031

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Sep 29, 2019

Shape calculations can happen in int64 (as shapes are IndexExpr). Compile engine already ensures that the shapes of all inputs are in int32 for the codegen. But, it missed to handle the output shapes. This causes problem for full operator.

@icemelon9 @zhiics @yzhliu @vinx13

@icemelon icemelon merged commit d0fe532 into apache:master Sep 30, 2019
@icemelon
Copy link
Member

Thanks @anijain2305

anijain2305 added a commit to anijain2305/tvm that referenced this pull request Oct 17, 2019
petrex added a commit to petrex/tvm that referenced this pull request Oct 29, 2019
* master:
  Fix split's last factor issue (apache#4044)
  [COMMUNITY] ajtulloch -> committer (apache#4043)
  [TOPI]Add op argwhere (apache#3994)
  [topi] add ARM v8.2 udot (uint8) support (apache#3978)
  [COMMUNITY] anijain2305 -> reviewer (apache#4036)
  [QNN] Renaming dense operator. (apache#4033)
  [Relay][Compile_engine] Int64 shape handling for outputs. (apache#4031)
  Add dmlc-core to the list of installed header directories. (apache#4035)
  [ARITH] migrate indexdiv/mod to floordiv/mod (apache#4008)
  [Relay] Move prelude to text format (apache#3939)
  make tvm compilable by gcc 4.9.2 (apache#4032)
  [AUTOTVM][DOCS] Add a link to the defining network description of auto-tuning tutorial (apache#4023)
  [ARITH] cleanup the indexmod/div on python side (apache#4028)
  [Fix] Add more pad_mode support for onnx converter (apache#4029)
  Add parser support for ReLU tflite operator (apache#4022)
  Additional MXNet Convolution and Deconvolution tests (apache#4026)
  docs: minor spelling tweaks (apache#4027)
@anijain2305 anijain2305 deleted the shape branch November 13, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants