Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[topi] enable fp16 sort for arm #4084

Merged
merged 1 commit into from
Oct 8, 2019
Merged

[topi] enable fp16 sort for arm #4084

merged 1 commit into from
Oct 8, 2019

Conversation

yzhliu
Copy link
Member

@yzhliu yzhliu commented Oct 8, 2019

NMS implement currently makes assumption that the constants are fp32, which will cause error compile fp16 models.

Need @icemelon9 's change to enable SSD though icemelon@b241fcb

Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Laurawly Laurawly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering if you are gonna add fp16 for GPU as well.

@yzhliu
Copy link
Member Author

yzhliu commented Oct 8, 2019

@Laurawly will do

@yzhliu yzhliu merged commit 1c56c72 into apache:master Oct 8, 2019
@yzhliu
Copy link
Member Author

yzhliu commented Oct 8, 2019

Thanks @icemelon9 @Laurawly . merge it for now.

anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Oct 17, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants