Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay][Frontend][ONNX] Add support for broadcasting to Where and MatMul #4267

Merged
merged 7 commits into from
Nov 7, 2019
Merged

[Relay][Frontend][ONNX] Add support for broadcasting to Where and MatMul #4267

merged 7 commits into from
Nov 7, 2019

Conversation

soiferj
Copy link
Contributor

@soiferj soiferj commented Nov 7, 2019

The x and y inputs of Where can be broadcast, as can the b matrix of MatMul.

@jwfromm would you mind taking a look?

jwfromm
jwfromm approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good changes, it all LGTM!

@tqchen tqchen merged commit 5bcd331 into apache:master Nov 7, 2019
@tqchen
Copy link
Member

tqchen commented Nov 7, 2019

Thanks @jwfromm @soiferj !

@soiferj soiferj deleted the onnxupdates branch November 11, 2019 23:35
zxy844288792 pushed a commit to neo-ai/tvm that referenced this pull request Nov 13, 2019
@soiferj
[Relay][Frontend][ONNX] Add support for broadcasting to Where and Mat…
bd0321b 
…Mul (apache#4267)
@tqchen tqchen mentioned this pull request Nov 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwfromm jwfromm jwfromm approved these changes

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soiferj @tqchen @jwfromm @jonso4