Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autotvm] Use VM compile to extract autotvm tasks #4328

Merged
merged 8 commits into from
Jan 9, 2020

Conversation

icemelon
Copy link
Member

Current autotvm relay integration doesn't support extract autotvm tasks from a module.

@icemelon
Copy link
Member Author

@tmoreau89 @merrymercy Could you help review the pr?

@comaniac
Copy link
Contributor

comaniac commented Nov 13, 2019

Did you measure the time to extract tasks using Relay VM?
The recent PR #4138 has optimized the task extraction time, so I am cauious if it would be faster or slower when using Relay VM.

@icemelon
Copy link
Member Author

Good point. I think it will slow down the task extraction time since it includes the codegen pass. I'll take a look and see if I can optimize it.

@icemelon
Copy link
Member Author

icemelon commented Jan 8, 2020

@comaniac @zhiics @wweic @tqchen Updated the PR. Could you help review it?

@comaniac
Copy link
Contributor

comaniac commented Jan 8, 2020

LGTM. Now the VM compilation has two steps, lower and codegen. Since we only need to run lower when extracting AutoTVM tasks, the extraction time should be much shorter.

Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, it might be necessary to put some comments under compile to mention that the two different ways invoking lowering and codegen.

@icemelon
Copy link
Member Author

icemelon commented Jan 8, 2020

@zhiics Do you mean in the VMCompiler class?

@zhiics
Copy link
Member

zhiics commented Jan 8, 2020

@icemelon9 yes, my bad.

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiics zhiics merged commit baae28b into apache:master Jan 9, 2020
@zhiics
Copy link
Member

zhiics commented Jan 9, 2020

Thanks @icemelon9 @comaniac @wweic @tmoreau89

@icemelon icemelon deleted the autotvm-relay branch January 9, 2020 01:16
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
* [AutoTVM] Use vm compile in extracting task from relay

* update

* restructure vm compiler to reduce task extraction time

* x

* fix

* update doc

* udpate doc

* lint
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
* [AutoTVM] Use vm compile in extracting task from relay

* update

* restructure vm compiler to reduce task extraction time

* x

* fix

* update doc

* udpate doc

* lint
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
* [AutoTVM] Use vm compile in extracting task from relay

* update

* restructure vm compiler to reduce task extraction time

* x

* fix

* update doc

* udpate doc

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants