-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autotvm] Use VM compile to extract autotvm tasks #4328
Conversation
@tmoreau89 @merrymercy Could you help review the pr? |
Did you measure the time to extract tasks using Relay VM? |
Good point. I think it will slow down the task extraction time since it includes the codegen pass. I'll take a look and see if I can optimize it. |
ab2a3e6
to
ed1dd3d
Compare
LGTM. Now the VM compilation has two steps, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, it might be necessary to put some comments under compile
to mention that the two different ways invoking lowering and codegen.
@zhiics Do you mean in the VMCompiler class? |
@icemelon9 yes, my bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @icemelon9 @comaniac @wweic @tmoreau89 |
* [AutoTVM] Use vm compile in extracting task from relay * update * restructure vm compiler to reduce task extraction time * x * fix * update doc * udpate doc * lint
* [AutoTVM] Use vm compile in extracting task from relay * update * restructure vm compiler to reduce task extraction time * x * fix * update doc * udpate doc * lint
* [AutoTVM] Use vm compile in extracting task from relay * update * restructure vm compiler to reduce task extraction time * x * fix * update doc * udpate doc * lint
Current autotvm relay integration doesn't support extract autotvm tasks from a module.