[Node] Allow Array/Map store objects that are not NodeRef #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Nov 26, 2019
|
@junrushao1994 Just out of curiosity, it looks that this will allow us to return runtime object refs like modules. Is this what you need? @tqchen do we want to move container.h under runtime at some point? |
|
@zhiics You are right. Array/Map/StrMap are designed to allow storing all possible objects.
I personally think that this could happen after we have containers with POD C ABI |
zhiics
approved these changes
Nov 26, 2019
leo-blonk
pushed a commit
to leo-blonk/tvm
that referenced
this pull request
Nov 29, 2019
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Dec 13, 2019
zxy844288792
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tqchen @icemelon9 Please review :-)